Re: [libvirt] [PATCH v8 10/21] conf: Add parameter to virDomainDiskSourceFormat

2019-05-06 Thread Eric Blake
On 4/25/19 7:46 AM, Peter Krempa wrote: > On Wed, Apr 17, 2019 at 09:09:10 -0500, Eric Blake wrote: >> Commits 4bc42986 and 218c81ea removed virDomainStorageSourceFormat on >> the grounds that there were no external callers; however, the upcoming >> backup code wants to output a (push mode) or

Re: [libvirt] [PATCH v8 10/21] conf: Add parameter to virDomainDiskSourceFormat

2019-04-25 Thread Peter Krempa
On Wed, Apr 17, 2019 at 09:09:10 -0500, Eric Blake wrote: > Commits 4bc42986 and 218c81ea removed virDomainStorageSourceFormat on > the grounds that there were no external callers; however, the upcoming > backup code wants to output a (push mode) or (pull > mode) element that is in all other

[libvirt] [PATCH v8 10/21] conf: Add parameter to virDomainDiskSourceFormat

2019-04-17 Thread Eric Blake
Commits 4bc42986 and 218c81ea removed virDomainStorageSourceFormat on the grounds that there were no external callers; however, the upcoming backup code wants to output a (push mode) or (pull mode) element that is in all other respects identical to a domain's element, where the previous