Re: [libvirt] [PATCH v8 2/4] Add vbox_snapshot_conf struct

2014-06-11 Thread John Ferlan
Ug... and trying to "locally" fix the RW/RO discovered two more issues... On 06/11/2014 08:21 AM, John Ferlan wrote: > > This patch has resulted in many new Coverity errors - mostly resource > leaks as a result of the virVBoxSnapshotConfAllChildren() recursive > function. I would clean them up,

Re: [libvirt] [PATCH v8 2/4] Add vbox_snapshot_conf struct

2014-06-11 Thread John Ferlan
One more here too - missed it in my last pass... On 05/19/2014 08:47 AM, Yohan BELLEGUIC wrote: <...snip...> > + > +/* > + *isCurrentSnapshot: Return 1 if 'snapshotName' corresponds to the > + *vboxSnapshotXmlMachinePtr's current snapshot, return 0 otherwise. > + */ > +int virVBoxSnapshotConf

Re: [libvirt] [PATCH v8 2/4] Add vbox_snapshot_conf struct

2014-06-10 Thread Daniel P. Berrange
On Mon, May 19, 2014 at 02:47:31PM +0200, Yohan BELLEGUIC wrote: > This structure contains the data to be saved in the VirtualBox XML file > and can be manipulated with severals exposed functions. > The structure is created by vboxSnapshotLoadVboxFile taking the > machine XML file. > It also can re