Re: [libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

2013-12-03 Thread Peter Krempa
On 12/03/13 00:01, Eric Blake wrote: > On 11/27/2013 04:15 AM, Michal Privoznik wrote: >> On 26.11.2013 17:49, Peter Krempa wrote: >>> To simplify operations on virDomainDiskHostDef arrays we will need deep >>> copy and freeing functions. Add and properly export them. >>> --- > >>> +if (VI

Re: [libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

2013-12-02 Thread Eric Blake
On 11/27/2013 04:15 AM, Michal Privoznik wrote: > On 26.11.2013 17:49, Peter Krempa wrote: >> To simplify operations on virDomainDiskHostDef arrays we will need deep >> copy and freeing functions. Add and properly export them. >> --- >> +if (VIR_STRDUP(dst->port, src->port) < 0) >> +

Re: [libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

2013-12-02 Thread Peter Krempa
On 11/27/13 12:15, Michal Privoznik wrote: > On 26.11.2013 17:49, Peter Krempa wrote: >> To simplify operations on virDomainDiskHostDef arrays we will need deep >> copy and freeing functions. Add and properly export them. >> --- >> src/conf/domain_conf.c | 55 >>

Re: [libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

2013-11-27 Thread Michal Privoznik
On 26.11.2013 17:49, Peter Krempa wrote: > To simplify operations on virDomainDiskHostDef arrays we will need deep > copy and freeing functions. Add and properly export them. > --- > src/conf/domain_conf.c | 55 > +--- > src/conf/domain_conf.h | 3

[libvirt] [PATCHv1.5 18/27] conf: Add functions to copy and free network disk source definitions

2013-11-26 Thread Peter Krempa
To simplify operations on virDomainDiskHostDef arrays we will need deep copy and freeing functions. Add and properly export them. --- src/conf/domain_conf.c | 55 +--- src/conf/domain_conf.h | 3 +++ src/libvirt_private.syms | 2 ++ 3 files changed