Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-09 Thread Daniel P . Berrangé
On Tue, Jul 09, 2019 at 12:55:18PM +0200, Jan Zerebecki wrote: > > On 09/07/2019 10.35, Daniel P. Berrangé wrote: > > If virtlogd is active, we do *not* want logrotate doing anything at all. > > Are you saying that to fix the bug at hand, I should be required to > first implement 2 features in

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-09 Thread Jan Zerebecki
On 09/07/2019 10.35, Daniel P. Berrangé wrote: > If virtlogd is active, we do *not* want logrotate doing anything at all. Are you saying that to fix the bug at hand, I should be required to first implement 2 features in virtlogd and replace the current logrotate config (none of which caused the

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-09 Thread Daniel P . Berrangé
On Tue, Jul 09, 2019 at 03:51:41AM +0200, Jan Zerebecki wrote: > > > On 08/07/2019 23.28, Jim Fehlig wrote: > > On 7/8/19 12:28 PM, Jan Zerebecki wrote: > >> With logrotates copytruncate when e.g. domain1 doesn't exist anymore > >> /var/log/libvirt/qemu/domain1.log will still exist after

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jim Fehlig
On 7/8/19 7:51 PM, Jan Zerebecki wrote: > > > On 08/07/2019 23.28, Jim Fehlig wrote: >> On 7/8/19 12:28 PM, Jan Zerebecki wrote: >>> With logrotates copytruncate when e.g. domain1 doesn't exist anymore >>> /var/log/libvirt/qemu/domain1.log will still exist after rotation even >>> though it will

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jan Zerebecki
On 08/07/2019 23.28, Jim Fehlig wrote: > On 7/8/19 12:28 PM, Jan Zerebecki wrote: >> With logrotates copytruncate when e.g. domain1 doesn't exist anymore >> /var/log/libvirt/qemu/domain1.log will still exist after rotation even >> though it will never be written to. When new domain names keep

Re: [libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jim Fehlig
On 7/8/19 12:28 PM, Jan Zerebecki wrote: > With logrotates copytruncate when e.g. domain1 doesn't exist anymore > /var/log/libvirt/qemu/domain1.log will still exist after rotation even > though it will never be written to. When new domain names keep getting > used this leads to a lot of empty

[libvirt] [PATCHv2] Do not keep empty log files for deleted domains

2019-07-08 Thread Jan Zerebecki
With logrotates copytruncate when e.g. domain1 doesn't exist anymore /var/log/libvirt/qemu/domain1.log will still exist after rotation even though it will never be written to. When new domain names keep getting used this leads to a lot of empty logfiles. This may lead to slowdown or lack of free