Roman Bogorodskiy wrote:
I'm going to push that with my comments squashed in, if no objections.
Pushed; sorry for the delay.
Roman Bogorodskiy
pgpxOZ4k1fRmz.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Wojciech Macek wrote:
Implement bhyveDomainCreteXML function.
s/Crete/Create/
---
src/bhyve/bhyve_driver.c | 67
1 file changed, 67 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 7187202..4ac89c1
Roman Bogorodskiy wrote:
+dom = virGetDomain(conn, vm-def-name, vm-def-uuid);
+if (!dom)
+goto cleanup;
+
+ret = virBhyveProcessStart(dom-conn, privconn, vm,
+ VIR_DOMAIN_RUNNING_BOOTED,
+
Implement bhyveDomainCreteXML function.
---
src/bhyve/bhyve_driver.c | 67
1 file changed, 67 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 7187202..4ac89c1 100644
--- a/src/bhyve/bhyve_driver.c
+++
Review-fixes, changes since last time:
- persistent flag is not reset to 0 anymore
- dom-id =vm-def-id is moved after domain startup
- duplicate of start_flags |= VIR_BHYVE_PROCESS_START_AUTODESTROY removed
- flag VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE is used instead of zero
-
