[libvirt] [PATCHv2] conf: Fix memory leaks in virStoragePoolDefParseSource

2012-05-09 Thread Alex Jia
Detected by valgrind. Leaks are introduced in commit 122fa379. src/conf/storage_conf.c: fix memory leaks. How to reproduce? $ make make -C tests check TESTS=storagepoolxml2xmltest $ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest actual result: ==28571== LEAK SUMMARY:

Re: [libvirt] [PATCHv2] conf: Fix memory leaks in virStoragePoolDefParseSource

2012-05-09 Thread Eric Blake
On 05/09/2012 04:49 AM, Alex Jia wrote: Detected by valgrind. Leaks are introduced in commit 122fa379. src/conf/storage_conf.c: fix memory leaks. How to reproduce? $ make make -C tests check TESTS=storagepoolxml2xmltest $ cd tests valgrind -v --leak-check=full ./storagepoolxml2xmltest

Re: [libvirt] [PATCHv2] conf: Fix memory leaks in virStoragePoolDefParseSource

2012-05-09 Thread Alex Jia
Thanks and pushed now. - Original Message - From: Eric Blake ebl...@redhat.com To: Alex Jia a...@redhat.com Cc: libvir-list@redhat.com Sent: Wednesday, May 9, 2012 11:03:50 PM Subject: Re: [libvirt] [PATCHv2] conf: Fix memory leaks in virStoragePoolDefParseSource On 05/09/2012 04:49 AM