Re: [libvirt] [PATCHv2] cpustat: fix regression when cpus are offline

2012-10-26 Thread Eric Blake
On 10/26/2012 02:50 PM, Peter Krempa wrote: >> >> +int >> +nodeGetCPUCount(void) >> +{ >> +#ifdef __linux__ >> +/* XXX should we also work on older kernels, like RHEL5, that lack >> + * cpu/present and cpu/online files? Those kernels also lack cpu >> + * hotplugging, so it would be a m

Re: [libvirt] [PATCHv2] cpustat: fix regression when cpus are offline

2012-10-26 Thread Peter Krempa
On 10/26/12 19:52, Eric Blake wrote: It turns out that the cpuacct results properly account for offline cpus, and always returns results for every possible cpu, not just the online ones. So there is no need to check the map of online cpus in the first place, merely only a need to know the maximu

[libvirt] [PATCHv2] cpustat: fix regression when cpus are offline

2012-10-26 Thread Eric Blake
It turns out that the cpuacct results properly account for offline cpus, and always returns results for every possible cpu, not just the online ones. So there is no need to check the map of online cpus in the first place, merely only a need to know the maximum possible cpu. Meanwhile, virNodeGetC