On Fri, Jan 21, 2011 at 01:06:58PM -0700, Eric Blake wrote:
The first bug has been present since before the time that commit
f8a519 (Dec 2008) tried to make the dispatch loop re-entrant.
Dereferencing eventLoop.handles outside the lock risks crashing, since
any other thread could have
On 01/27/2011 09:09 AM, Daniel P. Berrange wrote:
The second is a regression introduced in commit e6b68d7 (Nov 2010).
ACK
Now pushed.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital
The first bug has been present since before the time that commit
f8a519 (Dec 2008) tried to make the dispatch loop re-entrant.
Dereferencing eventLoop.handles outside the lock risks crashing, since
any other thread could have reallocated the array in the meantime.
It's a narrow race window,
On 01/21/2011 01:06 PM, Eric Blake wrote:
The first bug has been present since before the time that commit
f8a519 (Dec 2008) tried to make the dispatch loop re-entrant.
The second is a regression introduced in commit e6b68d7 (Nov 2010).
I'm splitting this into two commits (to make it easier
On 01/21/2011 02:07 PM, Eric Blake wrote:
On 01/21/2011 01:06 PM, Eric Blake wrote:
The first bug has been present since before the time that commit
f8a519 (Dec 2008) tried to make the dispatch loop re-entrant.
The second is a regression introduced in commit e6b68d7 (Nov 2010).
I'm
