[libvirt] [PATCHv2] nwfilter: don't log error if firewalld is disabled, improve diagnostics

2012-08-24 Thread Laine Stump
The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that virCommandWait would log an error just for the exit status being non-0 (and a more scary than useful error at that).

Re: [libvirt] [PATCHv2] nwfilter: don't log error if firewalld is disabled, improve diagnostics

2012-08-24 Thread Daniel Veillard
On Fri, Aug 24, 2012 at 02:39:48AM -0400, Laine Stump wrote: The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that virCommandWait would log an error just for the exit

Re: [libvirt] [PATCHv2] nwfilter: don't log error if firewalld is disabled, improve diagnostics

2012-08-24 Thread Laine Stump
On 08/24/2012 03:02 AM, Daniel Veillard wrote: On Fri, Aug 24, 2012 at 02:39:48AM -0400, Laine Stump wrote: The original patch to support firewalld in nwfilter wasn't personally checking the exit status of firewall-cmd, but was instead sending NULL in the *exitstatus arg, which meant that