Tested by: Royce Lv
Patch works as expected:
tested with cmd snapshot-create domain_name --disk-only
(1)when without hmp cmd support ,snapshot failed,0 size source file deleted
(2)when source file creating failed,no snapshot taken and no crash with
need_unlink flag set
--
libvir-list mailing
Noticed when testing new libvirt against old qemu that lacked the
snapshot_blkdev HMP command. Libvirt was mistakenly treating the
command as successful, and re-writing the domain XML to use the
just-created 0-byte file, rendering the domain broken on restart.
* src/qemu/qemu_monitor_text.c
On 10/18/2011 05:31 PM, Dave Allan wrote:
On Tue, Oct 18, 2011 at 04:04:57PM -0600, Eric Blake wrote:
Noticed when testing new libvirt against old qemu that lacked the
snapshot_blkdev HMP command. Libvirt was mistakenly treating the
command as successful, and re-writing the domain XML to use
On Tue, Oct 18, 2011 at 04:04:57PM -0600, Eric Blake wrote:
Noticed when testing new libvirt against old qemu that lacked the
snapshot_blkdev HMP command. Libvirt was mistakenly treating the
command as successful, and re-writing the domain XML to use the
just-created 0-byte file, rendering
