Re: [libvirt] [PATCHv2] storage: avoid null deref and leak on failure

2011-05-04 Thread Eric Blake
On 05/04/2011 11:56 AM, Laine Stump wrote: > On 05/04/2011 12:52 PM, Eric Blake wrote: >> Detected by clang. NULL deref added in commit 343a27a (Mar 11), >> but leak of voldef present since commit 2cd9b2d (Apr 09). >> >> * src/storage/storage_driver.c (storageVolumeCreateXML): Don't >> leak voldef

Re: [libvirt] [PATCHv2] storage: avoid null deref and leak on failure

2011-05-04 Thread Laine Stump
On 05/04/2011 12:52 PM, Eric Blake wrote: Detected by clang. NULL deref added in commit 343a27a (Mar 11), but leak of voldef present since commit 2cd9b2d (Apr 09). * src/storage/storage_driver.c (storageVolumeCreateXML): Don't leak voldef or dereference null volobj. --- v2: don't leave pool->v

[libvirt] [PATCHv2] storage: avoid null deref and leak on failure

2011-05-04 Thread Eric Blake
Detected by clang. NULL deref added in commit 343a27a (Mar 11), but leak of voldef present since commit 2cd9b2d (Apr 09). * src/storage/storage_driver.c (storageVolumeCreateXML): Don't leak voldef or dereference null volobj. --- v2: don't leave pool->volumes.objs pointing to stale memory on fail