Re: [libvirt] [PATCHv2] uml: sanity check external data before using it

2010-03-09 Thread Chris Lalancette
On 03/03/2010 11:52 AM, Eric Blake wrote: Otherwise, a malicious packet could cause a DoS via spurious out-of-memory failure. * src/uml/uml_driver.c (umlMonitorCommand): Validate that incoming data is reliable before using it to allocate/dereference memory. Don't report bogus errno on short

Re: [libvirt] [PATCHv2] uml: sanity check external data before using it

2010-03-09 Thread Eric Blake
On 03/09/2010 12:17 PM, Chris Lalancette wrote: if (nbytes sizeof res) { -virReportSystemError(errno, - _(incomplete reply %s), - cmd); +virReportSystemError(0, _(incomplete reply %s), cmd); +

Re: [libvirt] [PATCHv2] uml: sanity check external data before using it

2010-03-09 Thread Chris Lalancette
On 03/09/2010 04:31 PM, Eric Blake wrote: On 03/09/2010 12:17 PM, Chris Lalancette wrote: if (nbytes sizeof res) { -virReportSystemError(errno, - _(incomplete reply %s), - cmd); +

[libvirt] [PATCHv2] uml: sanity check external data before using it

2010-03-03 Thread Eric Blake
Otherwise, a malicious packet could cause a DoS via spurious out-of-memory failure. * src/uml/uml_driver.c (umlMonitorCommand): Validate that incoming data is reliable before using it to allocate/dereference memory. Don't report bogus errno on short read. Reported by Jim Meyering. ---