Re: [libvirt] [PATCHv2] util: ensure safe{read, write, zero} return is checked

2010-03-09 Thread Chris Lalancette
On 03/03/2010 01:47 PM, Eric Blake wrote: Based on a warning from coverity. The safe* functions guarantee complete transactions on success, but don't guarantee freedom from failure. snip diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index b7b2e09..d9cae8b 100644 ---

Re: [libvirt] [PATCHv2] util: ensure safe{read, write, zero} return is checked

2010-03-09 Thread Eric Blake
On 03/09/2010 11:53 AM, Chris Lalancette wrote: if (priv-errfd != -1) { -saferead(priv-errfd, errout, sizeof(errout)); +if (saferead(priv-errfd, errout, sizeof(errout)) 0) { +virReportSystemError(errno, %s, +

Re: [libvirt] [PATCHv2] util: ensure safe{read, write, zero} return is checked

2010-03-09 Thread Chris Lalancette
On 03/09/2010 02:09 PM, Eric Blake wrote: remoteDriverLock(priv); if (fds[1].revents) { DEBUG0(Woken up from poll by other thread); -saferead(priv-wakeupReadFD, ignore, sizeof(ignore)); +ignore_value (saferead(priv-wakeupReadFD, ignore,

[libvirt] [PATCHv2] util: ensure safe{read, write, zero} return is checked

2010-03-03 Thread Eric Blake
Based on a warning from coverity. The safe* functions guarantee complete transactions on success, but don't guarantee freedom from failure. * src/util/util.h (saferead, safewrite, safezero): Add ATTRIBUTE_RETURN_CHECK. * src/remote/remote_driver.c (remoteIO, remoteIOEventLoop): Ignore some