Re: [libvirt] [PATCHv2 01/12] pci: eliminate unused driver arg from virPCIDeviceDetach

2013-06-25 Thread Daniel P. Berrange
On Mon, Jun 24, 2013 at 11:05:27PM -0400, Laine Stump wrote: The driver arg to virPCIDeviceDetach is no longer used (the name of the stub driver is now set in the virPCIDevice object, and virPCIDeviceDetach retrieves it from there). Remove it. What happens when libvirtd is restarted ? Are we

Re: [libvirt] [PATCHv2 01/12] pci: eliminate unused driver arg from virPCIDeviceDetach

2013-06-25 Thread Laine Stump
On 06/25/2013 05:50 AM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 11:05:27PM -0400, Laine Stump wrote: The driver arg to virPCIDeviceDetach is no longer used (the name of the stub driver is now set in the virPCIDevice object, and virPCIDeviceDetach retrieves it from there). Remove it.

Re: [libvirt] [PATCHv2 01/12] pci: eliminate unused driver arg from virPCIDeviceDetach

2013-06-25 Thread Daniel P. Berrange
On Tue, Jun 25, 2013 at 12:35:03PM -0400, Laine Stump wrote: On 06/25/2013 05:50 AM, Daniel P. Berrange wrote: On Mon, Jun 24, 2013 at 11:05:27PM -0400, Laine Stump wrote: The driver arg to virPCIDeviceDetach is no longer used (the name of the stub driver is now set in the virPCIDevice

[libvirt] [PATCHv2 01/12] pci: eliminate unused driver arg from virPCIDeviceDetach

2013-06-24 Thread Laine Stump
The driver arg to virPCIDeviceDetach is no longer used (the name of the stub driver is now set in the virPCIDevice object, and virPCIDeviceDetach retrieves it from there). Remove it. --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hostdev.c | 2 +- src/util/virpci.c | 13 +