Re: [libvirt] [PATCHv2 02/16] storage: treat 'aio' like 'raw' at parse time

2012-10-15 Thread Eric Blake
On 10/14/2012 08:57 PM, Doug Goldstein wrote: On Sat, Oct 13, 2012 at 4:59 PM, Eric Blake ebl...@redhat.com wrote: We have historically allowed 'aio' as a synonym for 'raw' for back-compat to xen, but since a future patch will move to using an enum value, we have to pick one to be our

Re: [libvirt] [PATCHv2 02/16] storage: treat 'aio' like 'raw' at parse time

2012-10-15 Thread Eric Blake
On 10/15/2012 12:31 PM, Eric Blake wrote: Should I post a v2 that does: if (STREQ_NULLABLE(driverType, aio)) { /* In-place conversion to raw */ driverType[0] = 'r'; driverType[1] = 'a'; driverType[2] = 'w'; } Or, since this area of code is changed again later in the

Re: [libvirt] [PATCHv2 02/16] storage: treat 'aio' like 'raw' at parse time

2012-10-14 Thread Doug Goldstein
On Sat, Oct 13, 2012 at 4:59 PM, Eric Blake ebl...@redhat.com wrote: We have historically allowed 'aio' as a synonym for 'raw' for back-compat to xen, but since a future patch will move to using an enum value, we have to pick one to be our preferred output name. This is a slight change in the

[libvirt] [PATCHv2 02/16] storage: treat 'aio' like 'raw' at parse time

2012-10-13 Thread Eric Blake
We have historically allowed 'aio' as a synonym for 'raw' for back-compat to xen, but since a future patch will move to using an enum value, we have to pick one to be our preferred output name. This is a slight change in the XML, but the sexpr and xm outputs should still be identical. *