Re: [libvirt] [PATCHv2 03/11] qemu_monitor: Indicate when CPUModelInfo props report migratablity

2018-07-20 Thread Chris Venteicher
Quoting Jiri Denemark (2018-07-12 06:59:18) > On Mon, Jul 09, 2018 at 22:56:47 -0500, Chris Venteicher wrote: > > Renamed variable in CPUModelInfo such that > > props_migratable_valid is true when properties in CPUModelInfo > > have been updated to accurately indicate if property is / isn't > >

Re: [libvirt] [PATCHv2 03/11] qemu_monitor: Indicate when CPUModelInfo props report migratablity

2018-07-12 Thread Jiri Denemark
On Mon, Jul 09, 2018 at 22:56:47 -0500, Chris Venteicher wrote: > Renamed variable in CPUModelInfo such that > props_migratable_valid is true when properties in CPUModelInfo > have been updated to accurately indicate if property is / isn't > migratable. > > Property migratability is not returned

Re: [libvirt] [PATCHv2 03/11] qemu_monitor: Indicate when CPUModelInfo props report migratablity

2018-07-11 Thread Chris Venteicher
Quoting Collin Walling (2018-07-11 18:25:00) > Not sure if I agree with the renaming here. > > From what I understand, "if a cpu property is not migratable, then the > cpu model is also not migratable". > > So I think the original naming scheme is fine. Very much welcome the feedback here

Re: [libvirt] [PATCHv2 03/11] qemu_monitor: Indicate when CPUModelInfo props report migratablity

2018-07-11 Thread Collin Walling
Not sure if I agree with the renaming here. >From what I understand, "if a cpu property is not migratable, then the cpu model is also not migratable". So I think the original naming scheme is fine. On 07/09/2018 11:56 PM, Chris Venteicher wrote: > Renamed variable in CPUModelInfo such that >

[libvirt] [PATCHv2 03/11] qemu_monitor: Indicate when CPUModelInfo props report migratablity

2018-07-09 Thread Chris Venteicher
Renamed variable in CPUModelInfo such that props_migratable_valid is true when properties in CPUModelInfo have been updated to accurately indicate if property is / isn't migratable. Property migratability is not returned directly in QMP messages but rather is sometimes calculated within Libvirt