Re: [libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-10-21 Thread Hai Dong Li
On 10/21/2011 05:35 AM, Eric Blake wrote: On 10/19/2011 08:31 PM, Hai Dong Li wrote: This email is just for your attention. I'm relatively new to work in a community, so I didn't pay much attention to the readability of the comments last email. It seems comments lie in a large patch like this

Re: [libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-10-20 Thread Eric Blake
On 10/19/2011 11:51 AM, Peter Krempa wrote: On 09/29/2011 06:22 PM, Eric Blake wrote: Rather than having to adjust all callers in a chain to deal with indentation, it is nicer to have virBuffer do auto-indentation. virBufferAdd(const virBufferPtr buf, const char *str, int len) { unsigned

Re: [libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-10-19 Thread Peter Krempa
On 09/29/2011 06:22 PM, Eric Blake wrote: Rather than having to adjust all callers in a chain to deal with indentation, it is nicer to have virBuffer do auto-indentation. * src/util/buf.h (_virBuffer): Increase size. (virBufferAdjustIndent, virBufferGetIndent): New prototypes. *

Re: [libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-10-19 Thread Hai Dong Li
This email is just for your attention. I'm relatively new to work in a community, so I didn't pay much attention to the readability of the comments last email. It seems comments lie in a large patch like this is easily to be omitted. So I cut the codes, leave codes associated with the

Re: [libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-10-18 Thread Hai Dong Li
On 09/30/2011 12:22 AM, Eric Blake wrote: Rather than having to adjust all callers in a chain to deal with indentation, it is nicer to have virBuffer do auto-indentation. * src/util/buf.h (_virBuffer): Increase size. (virBufferAdjustIndent, virBufferGetIndent): New prototypes. *

Re: [libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-10-18 Thread Hai Dong Li
On 09/30/2011 12:22 AM, Eric Blake wrote: Rather than having to adjust all callers in a chain to deal with indentation, it is nicer to have virBuffer do auto-indentation. * src/util/buf.h (_virBuffer): Increase size. (virBufferAdjustIndent, virBufferGetIndent): New prototypes. *

[libvirt] [PATCHv2 04/13] virbuf: add auto-indentation support

2011-09-29 Thread Eric Blake
Rather than having to adjust all callers in a chain to deal with indentation, it is nicer to have virBuffer do auto-indentation. * src/util/buf.h (_virBuffer): Increase size. (virBufferAdjustIndent, virBufferGetIndent): New prototypes. * src/libvirt_private.syms (buf.h): Export new functions. *