Re: [libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-24 Thread Martin Kletzander
On Fri, Jul 17, 2015 at 02:43:33PM -0400, Laine Stump wrote: This patch provides qemu support for the contents of in for the two existing PCI controller types that need it (i.e. the two controller types that are backed by a device that must be specified on the qemu commandline): 1) pci-bridge

Re: [libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-23 Thread Laine Stump
On 07/23/2015 09:41 AM, Ján Tomko wrote: > [Reducing the cc-list for this one too] > > On Fri, Jul 17, 2015 at 02:43:33PM -0400, Laine Stump wrote: >> This patch provides qemu support for the contents of in >> for the two existing PCI controller types that need it >> (i.e. the two controller type

Re: [libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-23 Thread Ján Tomko
[Reducing the cc-list for this one too] On Fri, Jul 17, 2015 at 02:43:33PM -0400, Laine Stump wrote: > This patch provides qemu support for the contents of in > for the two existing PCI controller types that need it > (i.e. the two controller types that are backed by a device that must > be spec

Re: [libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-22 Thread John Ferlan
On 07/22/2015 04:18 PM, Laine Stump wrote: > On 07/22/2015 03:54 PM, John Ferlan wrote: ... >>> +if (deviceName && >>> +VIR_STRDUP(options->type, deviceName) < 0) >>> +goto cleanup; >>> + >> As has been told to me before - virStrdup/VIR_STR

Re: [libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-22 Thread Laine Stump
On 07/22/2015 03:54 PM, John Ferlan wrote: > > On 07/17/2015 02:43 PM, Laine Stump wrote: >> This patch provides qemu support for the contents of in >> for the two existing PCI controller types that need it >> (i.e. the two controller types that are backed by a device that must >> be specified on

Re: [libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: > This patch provides qemu support for the contents of in > for the two existing PCI controller types that need it > (i.e. the two controller types that are backed by a device that must > be specified on the qemu commandline): > > 1) pci-bridge - sets

[libvirt] [PATCHv2 06/17] qemu: implement subelement to

2015-07-17 Thread Laine Stump
This patch provides qemu support for the contents of in for the two existing PCI controller types that need it (i.e. the two controller types that are backed by a device that must be specified on the qemu commandline): 1) pci-bridge - sets type attribute default as "pci-bridge" 2) dmi-to-pci-b