Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

2018-02-14 Thread Daniel P . Berrangé
Tuesday, February 13, 2018 5:03:40 AM > > Subject: Re: [libvirt] [PATCHv2 1/1] include: function parameter names same > > in declaration > > > > Daniel P. Berrangé [2018-02-13, 09:47AM +]: > > > On Mon, Feb 12, 2018 at 03:24:03PM -0600, Chris Venteicher wrote: > &g

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

2018-02-14 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 12:03:40PM +0100, Bjoern Walk wrote: > Daniel P. Berrangé [2018-02-13, 09:47AM +]: > > On Mon, Feb 12, 2018 at 03:24:03PM -0600, Chris Venteicher wrote: > > > Headers use same function parameter names as definition code. > > > > > > In some cases in libvirt-domain and

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

2018-02-13 Thread Christopher Venteicher
- Original Message - > From: "Bjoern Walk" > To: "Daniel P. Berrangé" > Cc: "Chris Venteicher" , libvir-list@redhat.com > Sent: Tuesday, February 13, 2018 5:03:40 AM > Subject: Re: [libvirt] [PATCHv2 1/1] include: function parameter names s

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

2018-02-13 Thread Bjoern Walk
Daniel P. Berrangé [2018-02-13, 09:47AM +]: > On Mon, Feb 12, 2018 at 03:24:03PM -0600, Chris Venteicher wrote: > > Headers use same function parameter names as definition code. > > > > In some cases in libvirt-domain and libvirt-network an established > > naming pattern in the header files w

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

2018-02-13 Thread Daniel P . Berrangé
On Mon, Feb 12, 2018 at 03:24:03PM -0600, Chris Venteicher wrote: > Headers use same function parameter names as definition code. > > In some cases in libvirt-domain and libvirt-network an established > naming pattern in the header files was more consistent and informative > in which case the impl

[libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

2018-02-12 Thread Chris Venteicher
Headers use same function parameter names as definition code. In some cases in libvirt-domain and libvirt-network an established naming pattern in the header files was more consistent and informative in which case the implementation was modified in the c file. --- include/libvirt/libvirt-domain.h