Re: [libvirt] [PATCHv2 1/2] build: avoid close, system

2011-01-29 Thread Eric Blake
On 01/29/2011 04:40 AM, Matthias Bolte wrote: >> >> -VIR_FORCE_CLOSE(infd); >> +if (infd != STDIN_FILENO) >> +VIR_FORCE_CLOSE(infd); >> VIR_FORCE_CLOSE(null); >> -tmpfd = childout; /* preserve childout value */ >> -VIR_FORCE_CLOSE(tmpfd); >> -if (childerr > 0 && >>

Re: [libvirt] [PATCHv2 1/2] build: avoid close, system

2011-01-29 Thread Matthias Bolte
2011/1/29 Eric Blake : > * src/fdstream.c (virFDStreamOpenFile, virFDStreamCreateFile): > Use VIR_FORCE_CLOSE instead of close. > * tests/commandtest.c (mymain): Likewise. > * tools/virsh.c (editFile): Use virCommand instead of system. > * src/util/util.c (__virExec): Special case preservation of s

[libvirt] [PATCHv2 1/2] build: avoid close, system

2011-01-28 Thread Eric Blake
* src/fdstream.c (virFDStreamOpenFile, virFDStreamCreateFile): Use VIR_FORCE_CLOSE instead of close. * tests/commandtest.c (mymain): Likewise. * tools/virsh.c (editFile): Use virCommand instead of system. * src/util/util.c (__virExec): Special case preservation of std file descriptors to child. ---