Re: [libvirt] [PATCHv2 1/2] qemu: Add missing lock of virDomainObj before calling virDomainUnref

2011-03-04 Thread Laine Stump
On 03/04/2011 06:47 AM, Daniel P. Berrange wrote: ACK Pushed. Thanks! -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2 1/2] qemu: Add missing lock of virDomainObj before calling virDomainUnref

2011-03-04 Thread Daniel P. Berrange
On Thu, Mar 03, 2011 at 04:10:07PM -0500, Laine Stump wrote: > (Eric pointed out in IRC that I should be acquiring the domainobj lock > prior to modifying obj->privateData->mon) > > This was found while researching the root cause of: > > https://bugzilla.redhat.com/show_bug.cgi?id=670848 > >

Re: [libvirt] [PATCHv2 1/2] qemu: Add missing lock of virDomainObj before calling virDomainUnref

2011-03-03 Thread Eric Blake
On 03/03/2011 02:10 PM, Laine Stump wrote: > (Eric pointed out in IRC that I should be acquiring the domainobj lock > prior to modifying obj->privateData->mon) > > The solution is to have qemuMonitorFree lock the domain object right > before unrefing it. Since the caller to qemuMonitorFree doesn'

[libvirt] [PATCHv2 1/2] qemu: Add missing lock of virDomainObj before calling virDomainUnref

2011-03-03 Thread Laine Stump
(Eric pointed out in IRC that I should be acquiring the domainobj lock prior to modifying obj->privateData->mon) This was found while researching the root cause of: https://bugzilla.redhat.com/show_bug.cgi?id=670848 virDomainUnref should only be called with the lock held for the virDomainObj