Re: [libvirt] [PATCHv2 1/2] security_dac: Rework to make it more readable

2014-04-16 Thread Ján Tomko
On 04/04/2014 02:34 PM, Michal Privoznik wrote: > While going through the security DAC code, I realized > it's a ragbag with plenty of thing we try to avoid. > For instance, callback data are passed as: > > void params[2]; > params[0] = mgr; > params[1] = def; > > Moreover, there's no

[libvirt] [PATCHv2 1/2] security_dac: Rework to make it more readable

2014-04-04 Thread Michal Privoznik
While going through the security DAC code, I realized it's a ragbag with plenty of thing we try to avoid. For instance, callback data are passed as: void params[2]; params[0] = mgr; params[1] = def; Moreover, there's no need to pass the whole virDomainDef in the callback as the only t