Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-29 Thread John Ferlan
On 10/10/2014 01:55 PM, akrow...@linux.vnet.ibm.com wrote: From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions to needed to synchronize the changes made to a guest domain network device's multicast filter with the corresponding macvtap device's filter

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-28 Thread Laine Stump
On 10/27/2014 06:54 PM, Tony Krowiak wrote: On 10/26/2014 12:12 PM, Laine Stump wrote: Note that I've attached a patch that addresses all the issues I raise in this review. Please try it out; if you approve, I will squash it in and push the result (with my name added as Signed-Off-By:, so that

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-27 Thread Tony Krowiak
On 10/26/2014 12:12 PM, Laine Stump wrote: Note that I've attached a patch that addresses all the issues I raise in this review. Please try it out; if you approve, I will squash it in and push the result (with my name added as Signed-Off-By:, so that you don't have to take all the blame if I

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-26 Thread Laine Stump
Note that I've attached a patch that addresses all the issues I raise in this review. Please try it out; if you approve, I will squash it in and push the result (with my name added as Signed-Off-By:, so that you don't have to take all the blame if I screwed something up :-)) Oh, and so that it is

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-14 Thread Laine Stump
I think you forgot to merge in your modifications from V1 - although the commit log is changed, the code is still the V1 patch :-) On 10/13/2014 03:52 PM, akrow...@linux.vnet.ibm.com wrote: From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions to needed to

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-14 Thread Laine Stump
On 10/14/2014 02:41 PM, Laine Stump wrote: I think you forgot to merge in your modifications from V1 - although the commit log is changed, the code is still the V1 patch :-) Ah, I see that you sent the actual V2 patch last weekend, and only sent this update to move the changes from V1 message

[libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-13 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions to needed to synchronize the changes made to a guest domain network device's multicast filter with the corresponding macvtap device's filter on the host: * Get/add/remove multicast MAC addresses * Get the

[libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-10 Thread akrowiak
From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions to needed to synchronize the changes made to a guest domain network device's multicast filter with the corresponding macvtap device's filter on the host: * Get/add/remove multicast MAC addresses * Get the

Re: [libvirt] [PATCHv2 1/2] util: Functions to update host network device's multicast filter

2014-10-10 Thread Eric Blake
[meta-comment] On 10/10/2014 11:55 AM, akrow...@linux.vnet.ibm.com wrote: From: Tony Krowiak akrow...@linux.vnet.ibm.com This patch provides the utility functions to needed to synchronize the changes made to a guest domain network device's multicast filter with the corresponding macvtap