On 08/18/2013 01:19 AM, Osier Yang wrote:
>>> +
>>> +if (!VIR_IS_CONNECTED_DOMAIN(dom)) {
>>> +virLibDomainError(VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
>>> +goto error;
>>> +}
>>> +
>> I wonder if we need to add a check for VIR_CONNECT_RO in this method.
>> Not sure whether
On 15/08/13 17:30, Daniel P. Berrange wrote:
On Thu, Aug 15, 2013 at 02:24:26AM +0530, nehaljwani wrote:
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index 52ac95d..fa49e70 100644
--- a/include/libvirt/libvirt.h.in
+++ b/include/libvirt/libvirt.h.in
@@ -2044,6 +2044,3
On Thu, Aug 15, 2013 at 02:24:26AM +0530, nehaljwani wrote:
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 52ac95d..fa49e70 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -2044,6 +2044,38 @@ int
> virDom
On 15/08/13 04:54, nehaljwani wrote:
Define a new API virDomainInterfacesAddresses, which returns
the address information of a running domain's interfaces(s).
If no interface name is specified, it returns the information
of all interfaces, otherwise it only returns the information
of the specific
Define a new API virDomainInterfacesAddresses, which returns
the address information of a running domain's interfaces(s).
If no interface name is specified, it returns the information
of all interfaces, otherwise it only returns the information
of the specificed interface. The address information i