Re: [libvirt] [PATCHv2 1/5] qemu: avoid adding in smbios arguments

2010-12-07 Thread Eric Blake
On 12/05/2010 12:57 AM, Daniel Veillard wrote: On Fri, Dec 03, 2010 at 02:56:14PM -0700, Eric Blake wrote: The log lists things like -smbios type=1,vendor=Red Hat, which is great for shell parsing, but not so great when you realize that execve() then passes those literal on as part of the

Re: [libvirt] [PATCHv2 1/5] qemu: avoid adding in smbios arguments

2010-12-05 Thread Daniel Veillard
On Fri, Dec 03, 2010 at 02:56:14PM -0700, Eric Blake wrote: The log lists things like -smbios type=1,vendor=Red Hat, which is great for shell parsing, but not so great when you realize that execve() then passes those literal on as part of the command line argument, such that qemu sets SMBIOS

[libvirt] [PATCHv2 1/5] qemu: avoid adding in smbios arguments

2010-12-03 Thread Eric Blake
The log lists things like -smbios type=1,vendor=Red Hat, which is great for shell parsing, but not so great when you realize that execve() then passes those literal on as part of the command line argument, such that qemu sets SMBIOS with extra literal quotes. The eventual addition of virCommand