Re: [libvirt] [PATCHv2 13/16] storage: use cache to walk backing chain

2012-10-17 Thread Eric Blake
On 10/16/2012 03:16 PM, Eric Blake wrote: +if (disk-format 0) +format = disk-format; +else if (ctl-allowDiskFormatProbing) +format = VIR_STORAGE_FILE_AUTO; +else +format = VIR_STORAGE_FILE_RAW; It seems like I've seen this same

Re: [libvirt] [PATCHv2 13/16] storage: use cache to walk backing chain

2012-10-16 Thread Laine Stump
On 10/13/2012 06:00 PM, Eric Blake wrote: We used to walk the backing file chain at least twice per disk, once to set up cgroup device whitelisting, and once to set up security labeling. Rather than walk the chain every iteration, which possibly includes calls to fork() in order to open

Re: [libvirt] [PATCHv2 13/16] storage: use cache to walk backing chain

2012-10-16 Thread Eric Blake
On 10/16/2012 02:51 PM, Laine Stump wrote: On 10/13/2012 06:00 PM, Eric Blake wrote: We used to walk the backing file chain at least twice per disk, once to set up cgroup device whitelisting, and once to set up security labeling. Rather than walk the chain every iteration, which possibly

[libvirt] [PATCHv2 13/16] storage: use cache to walk backing chain

2012-10-13 Thread Eric Blake
We used to walk the backing file chain at least twice per disk, once to set up cgroup device whitelisting, and once to set up security labeling. Rather than walk the chain every iteration, which possibly includes calls to fork() in order to open root-squashed NFS files, we can exploit the cache