Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

2011-07-14 Thread Eric Blake
On 07/14/2011 01:21 AM, Matthias Bolte wrote: >> +++ w/src/uml/uml_driver.c >> @@ -1599,7 +1599,9 @@ static char *umlDomainGetXMLDesc(virDomainPtr dom, >> virDomainObjPtr vm; >> char *ret = NULL; >> >> -virCheckFlags(0, NULL); >> +virCheckFlags(VIR_DOMAIN_XML_SECURE | >> +

Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

2011-07-14 Thread Matthias Bolte
2011/7/13 Eric Blake : > On 07/13/2011 06:41 AM, Matthias Bolte wrote: >> 2011/7/8 Eric Blake : >>> * src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc) >>> (umlDomainBlockPeek): Reject unknown flags. >>> --- >>>  src/uml/uml_driver.c |   14 +++--- >>>  1 files changed, 11 insertions(+), 3

Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

2011-07-13 Thread Eric Blake
On 07/13/2011 03:14 PM, Eric Blake wrote: >> Don't get fooled by the ATTRIBUTE_UNUSED again. All *DomainGetXMLDesc >> use virDomainDefFormat and have to accept all flags that >> virDomainDefFormat accepts. I suggest to recheck your series for this >> pattern, here it's just the first time that I no

Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

2011-07-13 Thread Eric Blake
On 07/13/2011 06:41 AM, Matthias Bolte wrote: > 2011/7/8 Eric Blake : >> * src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc) >> (umlDomainBlockPeek): Reject unknown flags. >> --- >> src/uml/uml_driver.c | 14 +++--- >> 1 files changed, 11 insertions(+), 3 deletions(-) >> > >> @@ -1559

Re: [libvirt] [PATCHv2 15/27] uml: reject unknown flags

2011-07-13 Thread Matthias Bolte
2011/7/8 Eric Blake : > * src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc) > (umlDomainBlockPeek): Reject unknown flags. > --- >  src/uml/uml_driver.c |   14 +++--- >  1 files changed, 11 insertions(+), 3 deletions(-) > > @@ -1559,11 +1562,14 @@ cleanup: > > >  static char *umlDomainGet

[libvirt] [PATCHv2 15/27] uml: reject unknown flags

2011-07-08 Thread Eric Blake
* src/uml/uml_driver.c (umlOpen, umlDomainGetXMLDesc) (umlDomainBlockPeek): Reject unknown flags. --- src/uml/uml_driver.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 6a396e4..9f66aee 100644 --- a/src/uml/