Re: [libvirt] [PATCHv2 16/16] blockjob: implement shallow commit flag in qemu

2012-10-17 Thread Laine Stump
On 10/13/2012 06:00 PM, Eric Blake wrote: Now that we can crawl the chain of backing files, we can do argument validation and implement the 'shallow' flag. In testing this, I discovered that it can be handy to pass the shallow flag and an explicit base, as a means of validating that the base

Re: [libvirt] [PATCHv2 16/16] blockjob: implement shallow commit flag in qemu

2012-10-17 Thread Eric Blake
On 10/17/2012 03:28 PM, Laine Stump wrote: On 10/13/2012 06:00 PM, Eric Blake wrote: Now that we can crawl the chain of backing files, we can do argument validation and implement the 'shallow' flag. In testing this, I discovered that it can be handy to pass the shallow flag and an explicit

[libvirt] [PATCHv2 16/16] blockjob: implement shallow commit flag in qemu

2012-10-13 Thread Eric Blake
Now that we can crawl the chain of backing files, we can do argument validation and implement the 'shallow' flag. In testing this, I discovered that it can be handy to pass the shallow flag and an explicit base, as a means of validating that the base is indeed the file we expected. *