On 03/31/2012 01:19 AM, Osier Yang wrote:
> On 03/30/2012 11:56 PM, Eric Blake wrote:
>> Commit 1b1402b introduced a regression. Since older libvirt versions
>> would silently round memory up (until the previous patch), but populated
>> current memory based on querying the guest, it was possible t
On 03/30/2012 08:36 PM, Zhou Peng wrote:
> Thanks for your patch serials.
> I think they fix the true bug.
>
> But I have a little doubt on the fuzz allowance, pls have a see
> comment in line below.
>
>> if (def->mem.cur_balloon > def->mem.max_balloon) {
>> -virDomainReportError(VIR
On 03/30/2012 11:56 PM, Eric Blake wrote:
Commit 1b1402b introduced a regression. Since older libvirt versions
would silently round memory up (until the previous patch), but populated
current memory based on querying the guest, it was possible to have
current> maximum by the amount of the round
Thanks for your patch serials.
I think they fix the true bug.
But I have a little doubt on the fuzz allowance, pls have a see
comment in line below.
On Fri, Mar 30, 2012 at 11:56 PM, Eric Blake wrote:
>
> Commit 1b1402b introduced a regression. Since older libvirt versions
> would silently roun
Commit 1b1402b introduced a regression. Since older libvirt versions
would silently round memory up (until the previous patch), but populated
current memory based on querying the guest, it was possible to have
current > maximum by the amount of the rounding. Accept this fuzz
factor, and silently
