Re: [libvirt] [PATCHv2 2/2] conf: snapshot: Don't default-snapshot empty drives

2014-09-12 Thread Peter Krempa
On 09/11/14 20:07, Eric Blake wrote: On 09/11/2014 11:54 AM, Peter Krempa wrote: If a (floppy) drive isn't selected for snapshot explicitly and is empty don't try to snapshot it. For external snapshots this would fail as we can't generate a name for the snapshot from an empty drive.

Re: [libvirt] [PATCHv2 2/2] conf: snapshot: Don't default-snapshot empty drives

2014-09-11 Thread Eric Blake
On 09/11/2014 11:54 AM, Peter Krempa wrote: If a (floppy) drive isn't selected for snapshot explicitly and is empty don't try to snapshot it. For external snapshots this would fail as we can't generate a name for the snapshot from an empty drive. Reported-by: Pavel Hrdina phrd...@redhat.com