Re: [libvirt] [PATCHv2 2/3] util: introduce virWaitPid

2010-12-11 Thread Eric Blake
On 12/10/2010 05:07 PM, Eric Blake wrote: > * src/util/util.h (virWaitPid): New prototype. > * src/util/util.c (virWaitPid): Implement it. > * src/util/command.c (virCommandWait): Use it. > * src/libvirt_private.syms: Export it. > --- > > Should I convert over most remaining instances of waitpid()

[libvirt] [PATCHv2 2/3] util: introduce virWaitPid

2010-12-10 Thread Eric Blake
* src/util/util.h (virWaitPid): New prototype. * src/util/util.c (virWaitPid): Implement it. * src/util/command.c (virCommandWait): Use it. * src/libvirt_private.syms: Export it. --- Should I convert over most remaining instances of waitpid() and add a 'make syntax-check' entry? The only place th