[libvirt] [PATCHv2 2/9] util: eliminate union in virNetDevVPortProfile

2012-08-14 Thread Laine Stump
virNetDevVPortProfile has (had) a type field that can be set to one of several values, and a union of several structs, one for each type. When a domain's interface object is of type network, the domain config may not know beforehand which type of virtualport is going to be provided in the actual

Re: [libvirt] [PATCHv2 2/9] util: eliminate union in virNetDevVPortProfile

2012-08-14 Thread Kyle Mestery (kmestery)
This looks good to me. Acked-by: Kyle Mestery kmest...@cisco.com On Aug 14, 2012, at 2:04 AM, Laine Stump wrote: virNetDevVPortProfile has (had) a type field that can be set to one of several values, and a union of several structs, one for each type. When a domain's interface object is of