Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Daniel Veillard
On Thu, Aug 23, 2012 at 02:54:16PM -0600, Eric Blake wrote: The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a virDomainSnapshotPtr. Also, a future patch will reuse the enum for declaring where the VM memory is stored.

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Eric Blake
On 08/24/2012 01:00 AM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 02:54:16PM -0600, Eric Blake wrote: The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a virDomainSnapshotPtr. Also, a future patch will reuse the

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Daniel Veillard
On Fri, Aug 24, 2012 at 09:49:38AM -0600, Eric Blake wrote: On 08/24/2012 01:00 AM, Daniel Veillard wrote: On Thu, Aug 23, 2012 at 02:54:16PM -0600, Eric Blake wrote: The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a

Re: [libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-24 Thread Eric Blake
On 08/24/2012 09:57 AM, Daniel Veillard wrote: ACK, the only annoyance is that the name being longuer the simple substitution leads to lines over 80 characters, I would be a proponent of dropping the indentation to the opening ( for the sake of keeping everything on one 80 char line

[libvirt] [PATCHv2 3/3] snapshot: rename an enum

2012-08-23 Thread Eric Blake
The name 'virDomainDiskSnapshot' didn't fit in with our normal conventions of using a prefix hinting that it is related to a virDomainSnapshotPtr. Also, a future patch will reuse the enum for declaring where the VM memory is stored. * src/conf/snapshot_conf.h (virDomainDiskSnapshot): Rename...