Re: [libvirt] [PATCHv2 3/5] audit: add qemu hooks for auditing cgroup events

2011-02-24 Thread Eric Blake
On 02/24/2011 03:08 AM, Daniel P. Berrange wrote: >> +/** >> + * qemuDomainCgroupAudit: >> + * @vm: domain making the cgroups ACL change >> + * @cgroup: cgroup that manages the devices >> + * @reason: either "allow" or "deny" >> + * @item: one of "all", "file", or "major" > > I'd be inclined to re

Re: [libvirt] [PATCHv2 3/5] audit: add qemu hooks for auditing cgroup events

2011-02-24 Thread Daniel P. Berrange
On Wed, Feb 23, 2011 at 05:03:01PM -0700, Eric Blake wrote: > * src/qemu/qemu_audit.h (qemuDomainCgroupAudit): New prototype. > * src/qemu/qemu_audit.c (qemuDomainCgroupAudit): Implement it. > * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Add audit. > * src/qemu/qemu_cgroup.c (qemuSetupDiskPathAl

[libvirt] [PATCHv2 3/5] audit: add qemu hooks for auditing cgroup events

2011-02-23 Thread Eric Blake
* src/qemu/qemu_audit.h (qemuDomainCgroupAudit): New prototype. * src/qemu/qemu_audit.c (qemuDomainCgroupAudit): Implement it. * src/qemu/qemu_driver.c (qemudDomainSaveFlag): Add audit. * src/qemu/qemu_cgroup.c (qemuSetupDiskPathAllow) (qemuSetupChardevCgroup, qemuSetupHostUsbDeviceCgroup) (qemuSet