[libvirt] [PATCHv2 4/5] network: change cleanup: to error: in network*() functions

2012-08-14 Thread Laine Stump
A later patch will be adding a counter that will be incremented/decremented each time an guest interface starts/stops using a particular network. For this to work, all types of networks need to go through a common return sequence rather than returning early. To setup for this, the existing cleanup:

Re: [libvirt] [PATCHv2 4/5] network: change cleanup: to error: in network*() functions

2012-08-14 Thread Eric Blake
On 08/14/2012 01:10 AM, Laine Stump wrote: > A later patch will be adding a counter that will be > incremented/decremented each time an guest interface starts/stops > using a particular network. For this to work, all types of networks > need to go through a common return sequence rather than return

Re: [libvirt] [PATCHv2 4/5] network: change cleanup: to error: in network*() functions

2012-08-14 Thread Kyle Mestery (kmestery)
Looks good. Acked-by: Kyle Mestery On Aug 14, 2012, at 2:10 AM, Laine Stump wrote: > A later patch will be adding a counter that will be > incremented/decremented each time an guest interface starts/stops > using a particular network. For this to work, all types of networks > need to go through

Re: [libvirt] [PATCHv2 4/5] network: change cleanup: to error: in network*() functions

2012-08-14 Thread Laine Stump
On 08/14/2012 10:47 AM, Eric Blake wrote: > On 08/14/2012 01:10 AM, Laine Stump wrote: >> @@ -3199,8 +3198,9 @@ networkReleaseActualDevice(virDomainNetDefPtr iface) >>dev->dev, dev->connections); >> } >> >> -ret = 0; >> cleanup: >> +ret = 0; >> +error: > Another