Re: [libvirt] [PATCHv2.5 08/10] qemu: conf: Add support for memory device cold(un)plug

2015-03-16 Thread Peter Krempa
On Fri, Mar 13, 2015 at 10:39:05 -0400, John Ferlan wrote: On 03/04/2015 11:24 AM, Peter Krempa wrote: Add a few helpers that allow to operate with memory device definitions on the domain config and use them to implement memory device coldplug in the qemu driver. ---

Re: [libvirt] [PATCHv2.5 08/10] qemu: conf: Add support for memory device cold(un)plug

2015-03-13 Thread John Ferlan
+ +int +virDomainMemoryInsert(virDomainDefPtr def, + virDomainMemoryDefPtr mem) +{ +int id = def-nmems; + +if (mem-info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE +virDomainDefHasDeviceAddress(def, mem-info)) { Hmm... so if our incoming mem has

Re: [libvirt] [PATCHv2.5 08/10] qemu: conf: Add support for memory device cold(un)plug

2015-03-13 Thread John Ferlan
On 03/04/2015 11:24 AM, Peter Krempa wrote: Add a few helpers that allow to operate with memory device definitions on the domain config and use them to implement memory device coldplug in the qemu driver. --- src/conf/domain_conf.c | 100 +++

[libvirt] [PATCHv2.5 08/10] qemu: conf: Add support for memory device cold(un)plug

2015-03-04 Thread Peter Krempa
Add a few helpers that allow to operate with memory device definitions on the domain config and use them to implement memory device coldplug in the qemu driver. --- src/conf/domain_conf.c | 100 +++ src/conf/domain_conf.h | 10 +