Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-09 Thread Eric Blake
On 04/08/2013 09:43 PM, Eric Blake wrote: >> Thanks; I can confirm under valgrind that we have a use after free, with >> all sorts of nasty heap corruption potential, after instrumenting my >> source a bit more: >> > >> >> Once again, I'm trying to ascertain how far back this issue appears. > > T

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 04/08/2013 08:27 PM, Eric Blake wrote: > On 04/08/2013 07:04 AM, Peter Krempa wrote: >>> Aiee, perhaps a race between a thread freeing a domain object (and the >>> private data) and another thread that happened to acquire the domain >>> object pointer before it was freed? Let me verify if that i

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 04/08/2013 07:04 AM, Peter Krempa wrote: >> Aiee, perhaps a race between a thread freeing a domain object (and the >> private data) and another thread that happened to acquire the domain >> object pointer before it was freed? Let me verify if that is possible. > > Ufff. The domain objects in th

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 04/08/2013 02:42 PM, Eric Blake wrote: > On 03/31/2013 10:20 AM, Peter Krempa wrote: >> This series fixes the crash resulting from a race condition in the connection >> close callback. To observe the crash apply the first patch only. To verify >> that >> the patchset fixes the crash please appl

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Eric Blake
On 03/31/2013 10:20 AM, Peter Krempa wrote: > This series fixes the crash resulting from a race condition in the connection > close callback. To observe the crash apply the first patch only. To verify > that > the patchset fixes the crash please apply all but 2/6 and verify using virsh. > 2/6 fixe

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Peter Krempa
On 04/08/13 14:06, Peter Krempa wrote: On 04/08/13 13:55, Viktor Mihajlovski wrote: I fear we're yet not thru this. Today I had a segfault doing a migration using virsh migrate --verbose --live $guest qemu+ssh://$host/system. This is with Friday's git HEAD. The migration took very long (but succ

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Peter Krempa
[Re-sending, there was probably a problem and the mail didn't reach the list apparently] On 04/08/13 14:06, Peter Krempa wrote: > On 04/08/13 13:55, Viktor Mihajlovski wrote: >> I fear we're yet not thru this. Today I had a segfault doing a migration >> using virsh migrate --verbose --live $gues

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Peter Krempa
On 04/08/13 13:55, Viktor Mihajlovski wrote: I fear we're yet not thru this. Today I had a segfault doing a migration using virsh migrate --verbose --live $guest qemu+ssh://$host/system. This is with Friday's git HEAD. The migration took very long (but succeeded except for the libvirt crash) so t

Re: [libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-04-08 Thread Viktor Mihajlovski
On 03/31/2013 06:20 PM, Peter Krempa wrote: > This series fixes the crash resulting from a race condition in the connection > close callback. To observe the crash apply the first patch only. To verify > that > the patchset fixes the crash please apply all but 2/6 and verify using virsh. > 2/6 fixe

[libvirt] [PATCHv3 0/6] Fix memory corruption/crash in the connection close callback

2013-03-31 Thread Peter Krempa
This series fixes the crash resulting from a race condition in the connection close callback. To observe the crash apply the first patch only. To verify that the patchset fixes the crash please apply all but 2/6 and verify using virsh. 2/6 fixes the crash in a redundant way in case the close callba