Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-16 Thread Ján Tomko
On Mon, Aug 15, 2016 at 11:01:22AM +0200, Boris Fiuczynski wrote: On 08/12/2016 04:59 PM, Ján Tomko wrote: On Fri, Aug 12, 2016 at 10:47:13AM +0200, Cornelia Huck wrote: On Thu, 11 Aug 2016 16:17:10 +0200 Ján Tomko wrote: On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-15 Thread Boris Fiuczynski
On 08/12/2016 04:59 PM, Ján Tomko wrote: On Fri, Aug 12, 2016 at 10:47:13AM +0200, Cornelia Huck wrote: On Thu, 11 Aug 2016 16:17:10 +0200 Ján Tomko wrote: On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote: >On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-12 Thread Laine Stump
On 08/11/2016 11:11 AM, Ján Tomko wrote: On Thu, Aug 11, 2016 at 10:17:34AM -0400, Laine Stump wrote: On 08/11/2016 09:31 AM, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-12 Thread Ján Tomko
On Fri, Aug 12, 2016 at 10:47:13AM +0200, Cornelia Huck wrote: On Thu, 11 Aug 2016 16:17:10 +0200 Ján Tomko wrote: On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote: >On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: >> On Thu, Aug 11, 2016 at

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-12 Thread Cornelia Huck
On Thu, 11 Aug 2016 16:17:10 +0200 Ján Tomko wrote: > On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote: > >On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: > >> On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: > >> > On Wed, Aug

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 10:17:34AM -0400, Laine Stump wrote: On 08/11/2016 09:31 AM, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Laine Stump
On 08/11/2016 09:31 AM, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: I'm wondering about generalizing this. eg what if

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 02:31:55PM +0100, Daniel P. Berrange wrote: On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: > On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: > > > > > > I'm wondering about

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 03:25:53PM +0200, Ján Tomko wrote: > On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: > > On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: > > > > > > > > > > I'm wondering about generalizing this. eg what if there are > > other device

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Ján Tomko
On Thu, Aug 11, 2016 at 01:00:08PM +0100, Daniel P. Berrange wrote: On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: I'm wondering about generalizing this. eg what if there are other device models where we want the ability to set a revision. We don't really want to invent a

Re: [libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 03:27:15PM +0200, Ján Tomko wrote: > > I'm wondering about generalizing this. eg what if there are other device models where we want the ability to set a revision. We don't really want to invent a new sub-elment named after each device model > Regards, Daniel --

[libvirt] [PATCHv3 04/11] Add virtio revision attribute to controllers

2016-08-10 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1227354 --- docs/formatdomain.html.in | 8 docs/schemas/domaincommon.rng | 3 +++ src/conf/domain_conf.c | 4