Re: [libvirt] [PATCHv3 1/2] VMware: Support more than 2 driver backends

2013-09-29 Thread Daniel Veillard
On Fri, Sep 27, 2013 at 06:03:03PM +0800, Daniel Veillard wrote: On Tue, Sep 24, 2013 at 11:24:30AM -0500, Doug Goldstein wrote: Currently the VMware version check code only supports two types of VMware backends, Workstation and Player. But in the near future we will have an additional one

Re: [libvirt] [PATCHv3 1/2] VMware: Support more than 2 driver backends

2013-09-27 Thread Matthias Bolte
2013/9/24 Doug Goldstein car...@cardoe.com: Currently the VMware version check code only supports two types of VMware backends, Workstation and Player. But in the near future we will have an additional one so we need to support more. Additionally, we discover and cache the path to the vmrun

Re: [libvirt] [PATCHv3 1/2] VMware: Support more than 2 driver backends

2013-09-27 Thread Daniel Veillard
On Tue, Sep 24, 2013 at 11:24:30AM -0500, Doug Goldstein wrote: Currently the VMware version check code only supports two types of VMware backends, Workstation and Player. But in the near future we will have an additional one so we need to support more. Additionally, we discover and cache the

Re: [libvirt] [PATCHv3 1/2] VMware: Support more than 2 driver backends

2013-09-27 Thread Ján Tomko
On 09/24/2013 06:24 PM, Doug Goldstein wrote: +driver-type = -1; +for (i = 0; i VMWARE_DRIVER_LAST; i++) { +if (STREQ(tmp, vmwareDriverTypeToString(i))) +driver-type = i; +} + You can use virEnumFromString for this: driver-type =

[libvirt] [PATCHv3 1/2] VMware: Support more than 2 driver backends

2013-09-24 Thread Doug Goldstein
Currently the VMware version check code only supports two types of VMware backends, Workstation and Player. But in the near future we will have an additional one so we need to support more. Additionally, we discover and cache the path to the vmrun binary so we should use that path when using the