On 09/11/2018 02:29 AM, Erik Skultety wrote:
> On Mon, Sep 10, 2018 at 01:17:43PM -0400, John Ferlan wrote:
>> [...]
>>
I would say:
* Returns 0 on success, -1 on error. Additionally, if the @error is
* non-zero, then the failure occurred during virNetlinkCommand, but
On Mon, Sep 10, 2018 at 01:17:43PM -0400, John Ferlan wrote:
> [...]
>
> >>
> >> I would say:
> >>
> >> * Returns 0 on success, -1 on error. Additionally, if the @error is
> >> * non-zero, then the failure occurred during virNetlinkCommand, but
> >> * no error message generated leaving it up to
On 2018-09-11 at 01:17, John Ferlan wrote:
>[...]
>
>>>
>>> I would say:
>>>
>>> * Returns 0 on success, -1 on error. Additionally, if the @error is
>>> * non-zero, then the failure occurred during virNetlinkCommand, but
>>> * no error message generated leaving it up to the caller to handle
>>>
[...]
>>
>> I would say:
>>
>> * Returns 0 on success, -1 on error. Additionally, if the @error is
>> * non-zero, then the failure occurred during virNetlinkCommand, but
>> * no error message generated leaving it up to the caller to handle
>> * the condition.
>
> "is generated" I guess?
>
>
On Mon, Sep 10, 2018 at 11:03:04AM -0400, John Ferlan wrote:
>
>
> On 09/10/2018 10:38 AM, Erik Skultety wrote:
> > On Fri, Sep 07, 2018 at 03:17:24PM +0800, Shi Lei wrote:
> >> This patch introduces virNetlinkNewLink helper which wraps the common
> >> libnl/netlink code to create a new link.
> >>
On 2018-09-10 at 22:38, Erik Skultety wrote:
>On Fri, Sep 07, 2018 at 03:17:24PM +0800, Shi Lei wrote:
>> This patch introduces virNetlinkNewLink helper which wraps the common
>> libnl/netlink code to create a new link.
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/libvirt_private.syms | 1 +
>> s
On 09/10/2018 10:38 AM, Erik Skultety wrote:
> On Fri, Sep 07, 2018 at 03:17:24PM +0800, Shi Lei wrote:
>> This patch introduces virNetlinkNewLink helper which wraps the common
>> libnl/netlink code to create a new link.
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/libvirt_private.syms | 1 +
>
On Fri, Sep 07, 2018 at 03:17:24PM +0800, Shi Lei wrote:
> This patch introduces virNetlinkNewLink helper which wraps the common
> libnl/netlink code to create a new link.
>
> Signed-off-by: Shi Lei
> ---
> src/libvirt_private.syms | 1 +
> src/util/virnetlink.c| 117 +++
This patch introduces virNetlinkNewLink helper which wraps the common
libnl/netlink code to create a new link.
Signed-off-by: Shi Lei
---
src/libvirt_private.syms | 1 +
src/util/virnetlink.c| 117 +++
src/util/virnetlink.h| 13 +
3 files change
