Re: [libvirt] [PATCHv3 1/6] flags: use common dumpxml flags check

2011-07-15 Thread Eric Blake
n 07/14/2011 04:42 PM, Eric Blake wrote: > The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases; > auditing the drivers found other places where flags was being used > but not validated. In particular, domainGetXMLDesc had issues with > clients accepting a different set of flags than

Re: [libvirt] [PATCHv3 1/6] flags: use common dumpxml flags check

2011-07-15 Thread Eric Blake
On 07/15/2011 09:25 AM, Matthias Bolte wrote: > 2011/7/15 Eric Blake : >> The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases; >> auditing the drivers found other places where flags was being used >> but not validated. In particular, domainGetXMLDesc had issues with >> clients accept

Re: [libvirt] [PATCHv3 1/6] flags: use common dumpxml flags check

2011-07-15 Thread Matthias Bolte
2011/7/15 Eric Blake : > The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases; > auditing the drivers found other places where flags was being used > but not validated.  In particular, domainGetXMLDesc had issues with > clients accepting a different set of flags than the common > virDo

[libvirt] [PATCHv3 1/6] flags: use common dumpxml flags check

2011-07-14 Thread Eric Blake
The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases; auditing the drivers found other places where flags was being used but not validated. In particular, domainGetXMLDesc had issues with clients accepting a different set of flags than the common virDomainDefFormat helper function. *