Re: [libvirt] [PATCHv3 18/19] blockjob: refactor qemu disk chain permission grants

2012-10-19 Thread Eric Blake
On 10/18/2012 12:50 PM, Laine Stump wrote: > On 10/17/2012 06:30 PM, Eric Blake wrote: >> Previously, snapshot code did its own permission granting (lock >> manager, cgroup device controller, and security manager labeling) >> inline. But now that we are adding block-commit and block-copy >> which

Re: [libvirt] [PATCHv3 18/19] blockjob: refactor qemu disk chain permission grants

2012-10-18 Thread Laine Stump
On 10/17/2012 06:30 PM, Eric Blake wrote: > Previously, snapshot code did its own permission granting (lock > manager, cgroup device controller, and security manager labeling) > inline. But now that we are adding block-commit and block-copy > which also have to change permissions, it's better to r

[libvirt] [PATCHv3 18/19] blockjob: refactor qemu disk chain permission grants

2012-10-17 Thread Eric Blake
Previously, snapshot code did its own permission granting (lock manager, cgroup device controller, and security manager labeling) inline. But now that we are adding block-commit and block-copy which also have to change permissions, it's better to reuse common code for the task. While snapshot sho