Re: [libvirt] [PATCHv3 2/6] virsh: Add vshCmdCompleter and vshOptCompleter

2013-09-03 Thread Eric Blake
On 09/01/2013 01:22 PM, Tomas Meszaros wrote: No, it should work like this: virsh# vol-key TAB vol1 vol2 --vol --pool virsh# vol-key --pool TAB pool1 pool2 Another twist to remember - options can be spelled with '=' in one argument, instead of two arguments. This means you have a choice

Re: [libvirt] [PATCHv3 2/6] virsh: Add vshCmdCompleter and vshOptCompleter

2013-09-01 Thread Tomas Meszaros
On 28/08/13 at 06:00am, Eric Blake wrote: [re-adding the list, which was accidentally omitted] On 08/28/2013 05:26 AM, Tomas Meszaros wrote: Per-option completions make sense. For example, 'virsh vol-key --pool TAB' wants to use a pool completer, while 'virsh vol-key --vol TAB' wants to

Re: [libvirt] [PATCHv3 2/6] virsh: Add vshCmdCompleter and vshOptCompleter

2013-08-28 Thread Tomas Meszaros
On 26/08/13 at 11:47am, Eric Blake wrote: On 08/26/2013 06:36 AM, Tomas Meszaros wrote: completer and completer_flags added to the _vshCmdDef and _vshCmdOptDef structures so it will be possible for completion generators to conveniently call completer functions with desired flags. ---

Re: [libvirt] [PATCHv3 2/6] virsh: Add vshCmdCompleter and vshOptCompleter

2013-08-28 Thread Eric Blake
[re-adding the list, which was accidentally omitted] On 08/28/2013 05:26 AM, Tomas Meszaros wrote: Per-option completions make sense. For example, 'virsh vol-key --pool TAB' wants to use a pool completer, while 'virsh vol-key --vol TAB' wants to use a volume completer; furthermore, 'virsh

[libvirt] [PATCHv3 2/6] virsh: Add vshCmdCompleter and vshOptCompleter

2013-08-26 Thread Tomas Meszaros
completer and completer_flags added to the _vshCmdDef and _vshCmdOptDef structures so it will be possible for completion generators to conveniently call completer functions with desired flags. --- tools/virsh.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/virsh.h

Re: [libvirt] [PATCHv3 2/6] virsh: Add vshCmdCompleter and vshOptCompleter

2013-08-26 Thread Eric Blake
On 08/26/2013 06:36 AM, Tomas Meszaros wrote: completer and completer_flags added to the _vshCmdDef and _vshCmdOptDef structures so it will be possible for completion generators to conveniently call completer functions with desired flags. --- tools/virsh.h | 7 +++ 1 file changed, 7