Re: [libvirt] [PATCHv4] Configure native vlan modes on Open vSwitch ports

2013-06-25 Thread John Ferlan
On 06/17/2013 01:56 PM, james robson wrote: ...snip... diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 2aee445..47e6027 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -109,8 +109,22 @@ int

Re: [libvirt] [PATCHv4] Configure native vlan modes on Open vSwitch ports

2013-06-24 Thread Laine Stump
On 05/23/2013 01:12 PM, james robson wrote: This patch adds functionality to allow libvirt to configure the 'native-tagged' and 'native-untagged' modes on openvswitch networks. v2 changes: Fix problems reported by Eric Blake v3 changes: Re work patch to address review comments v4

Re: [libvirt] [PATCHv4] Configure native vlan modes on Open vSwitch ports

2013-06-17 Thread james robson
Are there any comments on this iteration? On Thu, 2013-05-23 at 18:12 +0100, james robson wrote: This patch adds functionality to allow libvirt to configure the 'native-tagged' and 'native-untagged' modes on openvswitch networks. v2 changes: Fix problems reported by Eric Blake v3

Re: [libvirt] [PATCHv4] Configure native vlan modes on Open vSwitch ports

2013-06-17 Thread Laine Stump
On 06/17/2013 01:56 PM, james robson wrote: Are there any comments on this iteration? Sorry, it somehow got lost in my unread list mail. I'll do my best to review it before the end of the week. On Thu, 2013-05-23 at 18:12 +0100, james robson wrote: This patch adds functionality to allow

[libvirt] [PATCHv4] Configure native vlan modes on Open vSwitch ports

2013-05-23 Thread james robson
This patch adds functionality to allow libvirt to configure the 'native-tagged' and 'native-untagged' modes on openvswitch networks. v2 changes: Fix problems reported by Eric Blake v3 changes: Re work patch to address review comments v4 changes: Use enum for native modes --- diff --git