[libvirt] [PATCHv4] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-02-01 Thread ajia
From: Alex Jia a...@redhat.com Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % make -C tests check TESTS=networkxml2argvtest % cd tests valgrind -v --leak-check=full

Re: [libvirt] [PATCHv4] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-02-01 Thread Eric Blake
On 02/01/2012 02:22 AM, a...@redhat.com wrote: From: Alex Jia a...@redhat.com Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % make -C tests check TESTS=networkxml2argvtest

Re: [libvirt] [PATCHv4] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-02-01 Thread Eric Blake
On 02/01/2012 04:17 PM, Eric Blake wrote: @@ -516,7 +520,6 @@ networkBuildDnsmasqArgv(virNetworkObjPtr network, int i; for (i = 0; i dns-ntxtrecords; i++) { -char *record = NULL; if (virAsprintf(record, %s,%s,

Re: [libvirt] [PATCHv4] network: Avoid memory leaks on networkBuildDnsmasqArgv

2012-02-01 Thread Alex Jia
Thanks for your change and pushed. Regards, Alex - Original Message - From: Eric Blake ebl...@redhat.com Cc: a...@redhat.com, libvir-list@redhat.com Sent: Thursday, February 2, 2012 7:44:21 AM Subject: Re: [libvirt] [PATCHv4] network: Avoid memory leaks on networkBuildDnsmasqArgv On 02