On 03/11/2011 08:39 AM, Laine Stump wrote:
path, mode);
goto childerror;
}
-if (flags VIR_FILE_OP_RETURN_FD) {
+{
VIR_FORCE_CLOSE(pair[0]);
This VIR_FORCE_CLOSE(pair[0]) should be moved up to the very start of
the child
On 03/09/2011 08:45 PM, Eric Blake wrote:
This patch intentionally doesn't change indentation, in order to
make it easier to review the real changes.
* src/util/util.h (VIR_FILE_OP_RETURN_FD, virFileOperationHook):
Delete.
(virFileOperation): Rename...
(virFileOpenAs): ...and reduce parameters.
On Wed, Mar 09, 2011 at 06:45:49PM -0700, Eric Blake wrote:
This patch intentionally doesn't change indentation, in order to
make it easier to review the real changes.
More importantly it removes the hook function now.
* src/util/util.h (VIR_FILE_OP_RETURN_FD, virFileOperationHook):
This patch intentionally doesn't change indentation, in order to
make it easier to review the real changes.
* src/util/util.h (VIR_FILE_OP_RETURN_FD, virFileOperationHook):
Delete.
(virFileOperation): Rename...
(virFileOpenAs): ...and reduce parameters.
* src/util/util.c (virFileOperationNoFork,
