Re: [libvirt] [PATCHv4 12/15] qemu: use common API for reading difficult files

2011-03-26 Thread Eric Blake
On 03/25/2011 03:56 PM, Eric Blake wrote: > On 03/10/2011 05:14 AM, Daniel P. Berrange wrote: >> On Wed, Mar 09, 2011 at 07:18:30PM -0700, Eric Blake wrote: >>> Direct access to an open file is so much simpler than passing >>> everything through a pipe! >> >> Did you test with SELinux in enforcing

Re: [libvirt] [PATCHv4 12/15] qemu: use common API for reading difficult files

2011-03-25 Thread Eric Blake
On 03/10/2011 05:14 AM, Daniel P. Berrange wrote: > On Wed, Mar 09, 2011 at 07:18:30PM -0700, Eric Blake wrote: >> Direct access to an open file is so much simpler than passing >> everything through a pipe! > > Did you test with SELinux in enforcing mode - there's a very > slight chance this could

Re: [libvirt] [PATCHv4 12/15] qemu: use common API for reading difficult files

2011-03-10 Thread Daniel P. Berrange
On Wed, Mar 09, 2011 at 07:18:30PM -0700, Eric Blake wrote: > Direct access to an open file is so much simpler than passing > everything through a pipe! Did you test with SELinux in enforcing mode - there's a very slight chance this could impact things, though I think we do label all FDs correctly

[libvirt] [PATCHv4 12/15] qemu: use common API for reading difficult files

2011-03-09 Thread Eric Blake
Direct access to an open file is so much simpler than passing everything through a pipe! * src/qemu/qemu_driver.c (qemudOpenAsUID) (qemudDomainSaveImageClose): Delete. (qemudDomainSaveImageOpen): Rename... (qemuDomainSaveImageOpen): ...and drop read_pid argument. Use virFileOpenAs instead of qemu