Re: [libvirt] [PULL 04/45] numa: Fix QMP command set-numa-node error handling

On Thu, Oct 18, 2018 at 05:03:41PM -0300, Eduardo Habkost wrote: > From: Markus Armbruster > > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_numa_node() does that, and then exit()s. It > also passes &error_fatal to machine_set_cpu_numa_node(). Both

[libvirt] [PULL 04/45] numa: Fix QMP command set-numa-node error handling

From: Markus Armbruster Calling error_report() in a function that takes an Error ** argument is suspicious. parse_numa_node() does that, and then exit()s. It also passes &error_fatal to machine_set_cpu_numa_node(). Both wrong. Attempting to configure numa when the machine doesn't support it ki