Re: [libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-11-01 Thread Peter Krempa
On Thu, Oct 31, 2019 at 23:02:45 +0100, Paolo Bonzini wrote: > On 31/10/19 11:58, John Snow wrote: > > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > > I'd like to refactor these some day, and getting rid of the super-object > > will make that easier. > > > > Either

Re: [libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-11-01 Thread Paolo Bonzini
On 01/11/19 06:40, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 31/10/19 11:58, John Snow wrote: >>> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >>> I'd like to refactor these some day, and getting rid of the super-object >>> will make that easier. >>> >>>

Re: [libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread Markus Armbruster
Paolo Bonzini writes: > On 31/10/19 11:58, John Snow wrote: >> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >> I'd like to refactor these some day, and getting rid of the super-object >> will make that easier. >> >> Either way, we don't need this. > > Good idea. I

Re: [libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread Paolo Bonzini
On 31/10/19 11:58, John Snow wrote: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. > > Either way, we don't need this. Good idea. I will prepare a similar patch for

[libvirt] [PULL 1/9] IDE: deprecate ide-drive

2019-10-31 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster ACKed-by: