Re: [libvirt] [Patch 2/3]virsh: Make "DEBUG" loglevel the superset

2011-07-15 Thread Supriya Kannery
On 07/14/2011 05:28 PM, Jiri Denemark wrote: On Thu, Jun 30, 2011 at 13:52:32 +0530, Supriya Kannery wrote: va_start(ap, format); if (virVasprintf(&str, format, ap)< 0) { /* Skip debug messages on low memory */ This breaks make check for two reasons. First, it reverse

Re: [libvirt] [Patch 2/3]virsh: Make "DEBUG" loglevel the superset

2011-07-14 Thread Eric Blake
On 07/14/2011 05:58 AM, Jiri Denemark wrote: > On Thu, Jun 30, 2011 at 13:52:32 +0530, Supriya Kannery wrote: >> Aligning loglevel values of virsh to that of libvirt. >> "DEBUG"=0 loglevel, when specified through commandline or >> env variable, should log all the messages. "ERROR=4" >> should log

Re: [libvirt] [Patch 2/3]virsh: Make "DEBUG" loglevel the superset

2011-07-14 Thread Jiri Denemark
On Thu, Jun 30, 2011 at 13:52:32 +0530, Supriya Kannery wrote: > Aligning loglevel values of virsh to that of libvirt. > "DEBUG"=0 loglevel, when specified through commandline or > env variable, should log all the messages. "ERROR=4" > should log only error messages. > > Signed-off-by: Supriya

[libvirt] [Patch 2/3]virsh: Make "DEBUG" loglevel the superset

2011-06-30 Thread Supriya Kannery
Aligning loglevel values of virsh to that of libvirt. "DEBUG"=0 loglevel, when specified through commandline or env variable, should log all the messages. "ERROR=4" should log only error messages. Signed-off-by: Supriya Kannery --- tools/virsh.c | 12 1 file changed, 8 inserti